Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references for conformance #158

Closed
wants to merge 10 commits into from

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Sep 5, 2023

This renames all references and usages to the old crosstest repo so that they begin using the new connectrpc/conformance repository in the connectrpc organization.

Note this is not intended to merge (or build successfully) until the crosstest repo is officially moved.

Copy link
Collaborator

@rebello95 rebello95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming you've grepped the whole codebase for crosstest as well

- [Buf Studio][buf-studio]: Web UI for ad-hoc RPCs
- [connect-crosstest][connect-crosstest]: Connect, gRPC, and gRPC-Web
- [conformance][connect-conformance]: Connect, gRPC, and gRPC-Web
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [conformance][connect-conformance]: Connect, gRPC, and gRPC-Web
- [connect-conformance][connect-conformance]: Connect, gRPC, and gRPC-Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was actually decided to use just conformance for this link (see here and here). But I can make the link reference also be conformance for consistency if you like?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a super strong opinion, good to keep it consistent across repos

@smaye81 smaye81 changed the base branch from main to sayers/crosstest_text September 8, 2023 04:11
@smaye81
Copy link
Member Author

smaye81 commented Sep 8, 2023

Closing this because I'm going to split this up into PRs.

@smaye81 smaye81 closed this Sep 8, 2023
@smaye81 smaye81 deleted the sayers/conformance_refs branch September 12, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants